[Gmod-ajax] docs incorrect?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Gmod-ajax] docs incorrect?

Ben Bimber
Hello,

This page:


Says this:

Using VCF Filters in configuration

The two variables hideNotFilterPass or hideFilterPass can be used to define whether to filter some variants by default. For example adding hideNotFilterPass: 0 will show the variants that passed all filters by default (the track menu can be used to un-toggle this option too):

"hideNotFilterPass": 0


Isnt this slightly incorrect, or at least misleading?  hideNotFilterPass: 0 wont hide non-PASS variants, meaning it shows everything.  the sentence above seems to simply it is not showing failed variants (which it would).  perhaps something like this would be better?

The two variables hideNotFilterPass or hideFilterPass can be used to define whether to filter some variants by default. For example adding hideNotFilterPass: 0 will show all variants, both those that passed and failed filters, by default (the track menu can be used to un-toggle this option too).  Setting this to hideNotFilterPass: 1 default to hiding all variants that did not pass all filters.

-Ben




------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Gmod-ajax mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-ajax
Reply | Threaded
Open this post in threaded view
|

Re: docs incorrect?

Colin
I think it meant to say hideNotFilterPass: 1 instead of hideNotFilterPass: 0

Updated to reflect that. Good catch :)


-Colin

On Fri, Jul 8, 2016 at 11:49 AM, Ben Bimber <[hidden email]> wrote:
Hello,

This page:


Says this:

Using VCF Filters in configuration

The two variables hideNotFilterPass or hideFilterPass can be used to define whether to filter some variants by default. For example adding hideNotFilterPass: 0 will show the variants that passed all filters by default (the track menu can be used to un-toggle this option too):

"hideNotFilterPass": 0


Isnt this slightly incorrect, or at least misleading?  hideNotFilterPass: 0 wont hide non-PASS variants, meaning it shows everything.  the sentence above seems to simply it is not showing failed variants (which it would).  perhaps something like this would be better?

The two variables hideNotFilterPass or hideFilterPass can be used to define whether to filter some variants by default. For example adding hideNotFilterPass: 0 will show all variants, both those that passed and failed filters, by default (the track menu can be used to un-toggle this option too).  Setting this to hideNotFilterPass: 1 default to hiding all variants that did not pass all filters.

-Ben




------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Gmod-ajax mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-ajax



------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Gmod-ajax mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-ajax