[Gmod-tripal-devel] Tripal 1.0 - Minor Bug - Fix Suggestion

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Gmod-tripal-devel] Tripal 1.0 - Minor Bug - Fix Suggestion

Abraham Darius Llave IRRI
Good day people! 

So here I am trying Tripal as my superiors have chosen this as the best solution for our plans of setting up a centralized server for accessing genomic data in connection with our project. Last week I'm getting a lot of errors of which might cause me to send another email later - and while I was working on those, I noticed that Tripal 1.0 was finally released (Yey!). Therefore for obvious reasons, I have to walk through and follow the new version of tutorial, from the beginning, again. So, I already reached "Feature Page Configuration" section, but I get the error

warning: Invalid argument supplied for foreach() in /var/www/includes/form.inc on line 1271.
 
on my installation.
Inline image 1
^ Tutorial

Inline image 2
^ My installation. I'm planning to update to the current Drupal 6 version later on.

I subjected the object being passed to the foreach function, to the var_dump funcion  thus the dirty text in top of the page. 
The error message is triggered when the element with index '#default_value' is encountered - it is an empty string instead of an array, which is what the foreach function expects.
The code in question is at /var/www/sites/all/modules/tripal/tripal_feature/includes/tripal_feature.admin.inc
I have checked the current version at http://drupalcode.org/sandbox/spficklin/1337878.git/blob/HEAD:/tripal_feature/includes/tripal_feature.admin.inc and its line 324 is the same as mine thus triggering the error:

'#default_value' => variable_get('tax_classes', ''),
 
On my installation, I just changed it to this:

'#default_value' => variable_get('tax_classes', array())
 
and the error went away. 
So, this is for you reference. I don't dare change the code/commit to the project as early. 


Cheers.
--

Abraham Darius S. Llave

Associate - BioInformatics Support | C4 Rice Project

International Rice Research Institute

Los Baños, Laguna 4027

Republic of the Philippines

[hidden email]
+63-49-536-2701 extension 2643


 

This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author.

 

If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone except as permitted by the author sender.


The International Rice Research Institute is a member of the CGIAR consortium
------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to
tackle endpoint security challenges, access the full report.
http://p.sf.net/sfu/symantec-dev2dev
_______________________________________________
Gmod-tripal-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-tripal-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Gmod-tripal-devel] [Gmod-tripal] Tripal 1.0 - Minor Bug - Fix Suggestion

Stephen Ficklin-2
Hi Abraham,

We're always happy to receive corrections so thank you for noticing the warning and taking the time to find a fix. I have incorporated your change into the development branch of the code.  The warning should not affect the behavior of Tripal for you other than being an annoyance, but now will go away in future updates.

Thank for the feedback,
Stephen

On 3/12/2013 12:23 AM, Abraham Darius Llave (IRRI) wrote:
Good day people! 

So here I am trying Tripal as my superiors have chosen this as the best solution for our plans of setting up a centralized server for accessing genomic data in connection with our project. Last week I'm getting a lot of errors of which might cause me to send another email later - and while I was working on those, I noticed that Tripal 1.0 was finally released (Yey!). Therefore for obvious reasons, I have to walk through and follow the new version of tutorial, from the beginning, again. So, I already reached "Feature Page Configuration" section, but I get the error

warning: Invalid argument supplied for foreach() in /var/www/includes/form.inc on line 1271.
 
on my installation.
Inline image 1
^ Tutorial

Inline image 2
^ My installation. I'm planning to update to the current Drupal 6 version later on.

I subjected the object being passed to the foreach function, to the var_dump funcion  thus the dirty text in top of the page. 
The error message is triggered when the element with index '#default_value' is encountered - it is an empty string instead of an array, which is what the foreach function expects.
The code in question is at /var/www/sites/all/modules/tripal/tripal_feature/includes/tripal_feature.admin.inc
I have checked the current version at http://drupalcode.org/sandbox/spficklin/1337878.git/blob/HEAD:/tripal_feature/includes/tripal_feature.admin.inc and its line 324 is the same as mine thus triggering the error:

'#default_value' => variable_get('tax_classes', ''),
 
On my installation, I just changed it to this:

'#default_value' => variable_get('tax_classes', array())
 
and the error went away. 
So, this is for you reference. I don't dare change the code/commit to the project as early. 


Cheers.
--

Abraham Darius S. Llave

Associate - BioInformatics Support | C4 Rice Project

International Rice Research Institute

Los Baños, Laguna 4027

Republic of the Philippines

[hidden email]
+63-49-536-2701 extension 2643


 

This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author.

 

If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone except as permitted by the author sender.


The International Rice Research Institute is a member of the CGIAR consortium

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev


_______________________________________________
Gmod-tripal mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-tripal


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Gmod-tripal-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/gmod-tripal-devel