[galaxy-dev] user registration bug

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[galaxy-dev] user registration bug

Assaf Gordon-2
Hi,

Two minor issues with user registration:

1. If a user registers with an invalid public name (e.g. "A. Gordon 12345") a confusing red error message is shown:
     "User name must contain only lower-case letters, numbers and '-'"

It's confusing (IMHO) because a "user name" is usually associated with the name you're going to login with (which is the email in this case). The message should say "Public name must contain only...".
It'll also be nice to remove the word "user" from the "Public User name" label. "User name" is one thing, "Public name" is another. "Public User Name" is confusing.

2. After seeing the red warning about a bad public name AND fixing the name, clicking "submit" still gives the same red error message about a bad public user name.

Step to reproduce:

1. Go to main galaxy web site, select "Register" from the "user" menu.
2. Fill the fields with:
     email: [hidden email]
     password: 123456
     confirm password: 123456
     public user name: This.Is.an%Invalid-12345-Public-Name

3. Click "Submit"
     you'll get a red warning about an invalid user name.

4. change the public name to: ThisIsAValidPubLicName

5. Click "submit"
     you'll still get a red warning about an invalid user name.

The only way around this is to clear the public name field, and leave it empty when registering.

-gordon
_______________________________________________
galaxy-dev mailing list
[hidden email]
http://lists.bx.psu.edu/listinfo/galaxy-dev
Reply | Threaded
Open this post in threaded view
|

Re: [galaxy-dev] user registration bug

Greg Von Kuster
Hello Assaf,

On May 26, 2010, at 3:34 PM, Assaf Gordon wrote:

> Hi,
>
> Two minor issues with user registration:
>
> 1. If a user registers with an invalid public name (e.g. "A. Gordon 12345") a confusing red error message is shown:
>    "User name must contain only lower-case letters, numbers and '-'"
>
> It's confusing (IMHO) because a "user name" is usually associated with the name you're going to login with (which is the email in this case). The message should say "Public name must contain only...".
> It'll also be nice to remove the word "user" from the "Public User name" label. "User name" is one thing, "Public name" is another. "Public User Name" is confusing.
>

This is done, but not yet committed - will be soon.


> 2. After seeing the red warning about a bad public name AND fixing the name, clicking "submit" still gives the same red error message about a bad public user name.
>
> Step to reproduce:
>
> 1. Go to main galaxy web site, select "Register" from the "user" menu.
> 2. Fill the fields with:
>    email: [hidden email]
>    password: 123456
>    confirm password: 123456
>    public user name: This.Is.an%Invalid-12345-Public-Name
>
> 3. Click "Submit"
>    you'll get a red warning about an invalid user name.
>
> 4. change the public name to: ThisIsAValidPubLicName
>
> 5. Click "submit"
>    you'll still get a red warning about an invalid user name.
>
> The only way around this is to clear the public name field, and leave it empty when registering.

I have not been able to reproduce the above behavior - perhaps a caching issue?


>
> -gordon
> _______________________________________________
> galaxy-dev mailing list
> [hidden email]
> http://lists.bx.psu.edu/listinfo/galaxy-dev

Greg Von Kuster
Galaxy Development Team
[hidden email]




_______________________________________________
galaxy-dev mailing list
[hidden email]
http://lists.bx.psu.edu/listinfo/galaxy-dev
Reply | Threaded
Open this post in threaded view
|

Re: [galaxy-dev] user registration bug

Ramkrishna Chakrabarty
In reply to this post by Assaf Gordon-2

On May 26, 2010, at 3:34 PM, Assaf Gordon wrote:

> 4. change the public name to: ThisIsAValidPubLicName
>
> 5. Click "submit"
>    you'll still get a red warning about an invalid user name.

The public user name needs to have "... lower-case letters, numbers  
and '-'". Try resubmitting with a public user name containing all  
lowercase letters.

rc
_______________________________________________
galaxy-dev mailing list
[hidden email]
http://lists.bx.psu.edu/listinfo/galaxy-dev
Reply | Threaded
Open this post in threaded view
|

Re: [galaxy-dev] user registration bug

Assaf Gordon-2
"Lower case letters" !
I totally missed it... even I don't read those warnings sometimes (and I get upset when my users don't read the messages ;) ).

Perhaps it would be friendlier to silently convert the public name into all lower case and skip this hassle...


On 05/26/2010 03:56 PM, Ramkrishna Chakrabarty wrote:

>
> On May 26, 2010, at 3:34 PM, Assaf Gordon wrote:
>
>> 4. change the public name to: ThisIsAValidPubLicName
>>
>> 5. Click "submit"
>> you'll still get a red warning about an invalid user name.
>
> The public user name needs to have "... lower-case letters, numbers and
> '-'". Try resubmitting with a public user name containing all lowercase
> letters.
>
> rc

_______________________________________________
galaxy-dev mailing list
[hidden email]
http://lists.bx.psu.edu/listinfo/galaxy-dev